Draft
Conversation
ruff check --target-version py38 --select UP --fix .
Even debian oldstable has python 3.9. For internet-facing libraries it is not secure for contributor to install unsupported python versions in order to test them. Reducing the number of python versions will make maintenance and testing easier. is not secure to contributor to install unsupported python versions in order to test them.
Author
|
I will continue to look at this when #580 is merged. Currently it still has some errors in it. |
|
@Mic92 I found two, on line 133 and 135 of |
Author
|
I was mainly looking at the test suite failing. |
Author
|
Good to know there is a potential fork to switch to in the future. |
@Mic92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #580